Skip to content

Remove ToPublicKey bound for max_satisfaction_weight #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Remove ToPublicKey bound for max_satisfaction_weight #436

merged 1 commit into from
Jun 28, 2022

Conversation

@Eunoia1729
Copy link
Contributor

@Eunoia1729 Eunoia1729 commented Jun 23, 2022

Resolves: #432

SarcasticNastik
SarcasticNastik previously approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@SarcasticNastik SarcasticNastik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You can move the method in the previous impl <Pk: MiniscriptKey> .. block.

@SarcasticNastik
Copy link
Contributor

SarcasticNastik commented Jun 23, 2022

ACK edf7587

@Eunoia1729
Copy link
Contributor Author

Eunoia1729 commented Jun 23, 2022

nit: You can move the method in the previous impl <Pk: MiniscriptKey> .. block.

I was keen into minimising line changes but your suggestion seems more better. Thanks for the review!

apoelstra
apoelstra approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK edf7587

sanket1729
sanket1729 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK edf7587

@sanket1729 sanket1729 merged commit d589fe9 into rust-bitcoin:master Jun 28, 2022
heap-coder added a commit to heap-coder/rust-miniscript that referenced this pull request Sep 27, 2025
@heap-coder
Merge rust-bitcoin/rust-miniscript#436: Remove ToPublicKey bound for …
538f5de 
…max_satisfaction_weight

edf75875735b99ff6368c920405dff0fb32c35ce Remove ToPublicKey bound for max_satisfaction_weight (eunoia_1729)

Pull request description:

  Resolves: #432

ACKs for top commit:
  SarcasticNastik:
    ACK edf7587
  apoelstra:
    ACK edf75875735b99ff6368c920405dff0fb32c35ce
  sanket1729:
    ACK edf75875735b99ff6368c920405dff0fb32c35ce

Tree-SHA512: 57ca26abf31d5022ded5f7ca82f652605794a1c9f0d6b483158018865f4815d8298621ecd0e90af59bfebb70095a039f83b2873b0d245864b2fece480c648c65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

+1 more reviewer

@SarcasticNastik SarcasticNastik SarcasticNastik left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Descriptor::max_satisfaction_weight should not require a ToPublicKey bound

4 participants

@Eunoia1729 @SarcasticNastik @apoelstra @sanket1729